Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHP 5.3+ IDN funcion #38

Closed
registrobr opened this issue Jan 22, 2014 · 4 comments
Closed

Use PHP 5.3+ IDN funcion #38

registrobr opened this issue Jan 22, 2014 · 4 comments
Assignees
@fkyanai
Labels
enhancement wontfix

Comments

@registrobr
Copy link
Collaborator

PHP 5.3+ has functions to do IDN conversion; using instead of library simplifies distribution.

http://www.php.net/manual/en/function.idn-to-utf8.php
@registrobr registrobr mentioned this issue Mar 13, 2015
Open
@registrobr
Copy link
Collaborator Author

It also possible interacts with issue #51

@rubenskuhl
Copy link
Contributor

WHMCS 6.0 already makes PHP 5.3.7+ a requirement.

@rubenskuhl
Copy link
Contributor

PHP version requirement should also be tested in install script.

@rubenskuhl rubenskuhl mentioned this issue Jun 13, 2016
Closed
@rubenskuhl
Copy link
Contributor

IDN libraries are not included by default. Will leave the add-on as is in order to not generate an additional install requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkyanai fkyanai

Labels
enhancement wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkyanai @rubenskuhl