Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: User Defined List of Strings to Exclude When Searching for Artists or Albums #10

Open
classicjazz opened this issue May 15, 2021 · 3 comments

Comments

@classicjazz
Copy link

classicjazz commented May 15, 2021

Users should have the option to define specific strings that will be stripped from the artist or album tag to increase the likelihood of a match, without having identical artist/album names to those listed in Apple Music. Ideally, this would be defined in a text file.

For example, I would like to exclude the following strings:

(Children’s)
(Christmas)
(Holiday)
[Live]
(Live)
and his orchestra
& his orchestra
and her orchestra
& her orchestra
: music from the original motion picture
 - music from the motion picture
(original soundtrack)

or even

(wildcard)
[wildcard]
@classicjazz
Copy link
Author

classicjazz commented Jun 8, 2021

Expanding upon the wildcard concept, adding " feat. *" and " feat *" would likely fix songs which include a feature artist that is different from the primary artist

@regosen
Copy link
Owner

regosen commented Jun 8, 2021

I'm not sure I understand this. get_cover_art doesn't use the song title when searching for matches, only the artist and album. It only uses the title for outputting the artwork filename (and only if the user specified it in art-dest-filename or external-art-filename)

@classicjazz
Copy link
Author

Sorry, I meant songs...

I believe that get_cover_art is doing a lookup for each song using existing [artist] and [album] metadata. If there is extraneous metadata, it causes the search to fail even though Apple Music has the artwork for that album.

Currently, punctuation is removed but--reviewing my skip_artwork.txt--get_cover_art appears to not strip parenthetical data (i.e. words in parentheses or brackets in the artist or album field) or words in the artist name including "feat. [name of featured artist]".

For example, George Strait Feat Willie Nelson - Honky Tonk Time Machine should be normalized to
[George Strait] and [Honky Tonk Time Machine]

As noted initially, other extraneous data that causes the search to fail include user-added parentheticals such as (holiday) or different stylings of an artist name such as the inclusion of "and his orchestra" for classical music/big band. Similarly, motion picture album metadata may have a lot of variants, so reducing the search term in the soundtrack album name will improve results.

For example, Celine Dion - Deadpool 2 Original Motion Picture Soundtrack should be normalized to
[Celine Dion] and [Deadpool 2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants