Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rever check stopped in bash #217

Closed
anki-code opened this issue May 5, 2020 · 10 comments · Fixed by #226
Closed

rever check stopped in bash #217

anki-code opened this issue May 5, 2020 · 10 comments · Fixed by #226

Comments

@anki-code
Copy link
Contributor

anki-code commented May 5, 2020

Hi! This is my first try to use rever.

The rever.xsh file is in #216.

When I run rever check from bash it stops:

xonsh$ bash
bash$ cd ~/git/xontrib-prompt-bar
bash$ rever check
No checks needed for tag activity
All CLI and import requirements met for push_tag activity

[1]+  Stopped                 rever check

It looks like the same as xonsh/xonsh#3555

What I'm doing wrong?

@anki-code anki-code changed the title rever check Stopped rever check stopped in bash May 5, 2020
@hadim
Copy link
Contributor

hadim commented Aug 12, 2020

I observe the same issue. Sometimes it works sometimes it doesn't and I can't find the cause of it.

@hadim
Copy link
Contributor

hadim commented Aug 12, 2020

The issue only happen when executing rever from master (0.4.4). When installing from conda or git checkout 0.4.3 it works ok.

I am working on a PR to add an activity right now. I will have to make build it on top of 0.4.3 and not master.

I also had to fix xonsh to 0.9.18.

@scopatz
Copy link
Collaborator

scopatz commented Aug 14, 2020

Yeah, I have seen this issue too on mac. Rolling back to xonsh=0.9.18 rever=0.4.3 seems to fix it. I think the error is in xonsh, but if anyone can help figure out what the regression is that would be awesome!

@scopatz
Copy link
Collaborator

scopatz commented Aug 17, 2020

This does seem to be an issue running in Bash. I don't see this issue in xonsh, but I can reproduce it in Linux. So we know it is not some weird mac issue

@hadim
Copy link
Contributor

hadim commented Aug 17, 2020

My main station is Ubuntu 20.04 so I can confirm this issue also happens on Linux. And my shell is the regular bash shipped with Ubuntu.

@scopatz
Copy link
Collaborator

scopatz commented Aug 17, 2020

Minimal reproducible example at https://gitter.im/xonsh/xonsh?at=5f39d1745ccdf30c584ddd8b makes me think this is a pure xonsh issue

@scopatz
Copy link
Collaborator

scopatz commented Aug 20, 2020

Doing a git bisect, the problematic commit seems to be 921f284b22c30f78a33cdcad78d7bec99e18c744 in xonsh

@scopatz
Copy link
Collaborator

scopatz commented Aug 20, 2020

Nm, I just reran this with better repo cleaning and the bug seems to be in a8d4a57f01a25b1ce77f0a3adec1c0b11f49ad1a

@scopatz
Copy link
Collaborator

scopatz commented Aug 21, 2020

@anki-code @hadim - #226 should address this if either of you would like to test it out

@hadim
Copy link
Contributor

hadim commented Aug 21, 2020

Will try it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants