Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about Trooper #32

Closed
ebridges opened this issue Jul 15, 2013 · 2 comments
Closed

Questions about Trooper #32

ebridges opened this issue Jul 15, 2013 · 2 comments

Comments

@ebridges
Copy link

Hi!

I'm checking out Trooper, it looks like a terrific product that you've built on top of Spring Batch Admin!

We really like how you've added in the capability to upload entire jobs. We would like to have a standalone console that enables us to simply add jobs without having to redeploy the entire console, and it appears that Trooper provides this.

  • When adding jobs to Trooper, is it possible to simply upload a single jar file that contains a single job (or a collection of logically related jobs)? The jar file would be a "fat" jar consist of a folder (e.g. /META-INF/spring/batch/jobs) with XML job configurations and all dependencies of the job.
  • The original Spring Batch Admin console has a feature for uploading data files. It appears that this has been removed from Trooper. Is there a limitation in Trooper that prevents that from being available? How much work would it be (for you or an outsider) to add that back in?

Thanks!

@regunathb
Copy link
Owner

You are right, Trooper does allow you to deploy jobs (job binaries, config and dependency binaries) on the fly and not require a restart of the console/app. It also has the ability to propagate these deployments across a cluster, if you use the batch-HA mode.

All of these are however done on a per-job basis. We prefer it this way as we can maintain job specific config files, classpaths and eventually job-specific Spring application contexts.
The feature for uploading data files has been disabled/removed for this reason.

The good news however is that we use Spring MVC and Http GET/POST to retrieve/update job configurations and dependencies. It is therefore quite possible to add another method in the controller with appropriate @RequestMapping to receive and process a "fat" jar that follows the structure that you have described. The controller can unpack the jar and deploy jobs individually as is done currently.

Is this something you might consider implementing? The code is reasonably contained and is in org.trpr.platform.batch.impl.spring.web.JobConfigController

(https://github.com/regunathb/Trooper/blob/master/batch-core/src/main/java/org/trpr/platform/batch/impl/spring/web/JobConfigController.java)

@regunathb
Copy link
Owner

Closing this issue as it is not a feature we want to implement now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants