-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use/depend on user-agents package for better analysis of user agent strings? #11
Comments
sounds like an interesting idea. just a couple of thoughts:
also feel free to submit a pull request so that it's easier to compare the changes. |
Thanks for the fast reply! I should have been clearer about the removal of the cookies code (and the lack of a PR) - I did it to simplify the proof-of-concept (which I have running locally). I am more than happy to submit a proper, cleanly edited PR with additional decorators if you are interested. My main question is: are you happy to have a dependency on Re the new attributes on the Is that an issue? A compromise would be to introduce something like |
Sorry about the delay getting back to you. I'm fine with making I would like to ensure this stays backwards compatible so I like the idea of having Thanks! |
Thanks for the thumbs up. I will aim to pull something when I next make a related change in the client webapp, so can't be sure of a timeline just yet. I will try to make |
I thought about make the same thing using the |
@helielson i might get around to adding this in the next few weeks |
I've recently been using Flask-Mobility for a project or two (so thank you!) and quickly reached the point where I (a) needed more power, but (b) wanted to keep using the Flask-Mobility API/interface.
What do you think about using
user-agents
( https://github.com/selwin/python-user-agents/ ) to support finer-grained and more accurate analysis if UAs, in place of the current regex approach?I've just forked the repo to create a proof-of-concept: wodow@6b92262#diff-9da72ae617e53ab1abe6152bb885ed15
The text was updated successfully, but these errors were encountered: