Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with SVG elements #21

Open
mdekrey opened this issue May 27, 2019 · 0 comments · May be fixed by #28
Open

Does not work with SVG elements #21

mdekrey opened this issue May 27, 2019 · 0 comments · May be fixed by #28

Comments

@mdekrey
Copy link

mdekrey commented May 27, 2019

offsetHeight/offsetWidth do not work with elements often in the DOM that are not actually HTML Elements, for example, SVG elements.

I'd recommend using clientHeight/clientWidth when the offset versions are undefined, but it could be considered a breaking change.

Another possibility would be to allow the passing of a callback to override getSize.
@osdiab osdiab linked a pull request Mar 4, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get width and height from bounding client rect osdiab/component-size
1 participant
@mdekrey