Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Broken master / Beta builds not from master #1260

Closed
skmp opened this issue Aug 7, 2018 · 6 comments
Closed

Broken master / Beta builds not from master #1260

skmp opened this issue Aug 7, 2018 · 6 comments
Labels
important

Comments

@skmp
Copy link
Owner

skmp commented Aug 7, 2018

38539a9 broke master @dmiller423 I've reverted it and pushed your changes as dm/cdi-warn-and-ngen-fixes
skmp added a commit that referenced this issue Aug 7, 2018
@skmp
Revert "ngen_mainloop for x86 updated to use PC value from context, C…
b121fd1 
…DI warning"

This reverts commit 38539a9.
Reason: Breakage reported by beta testers

See #1260
@skmp
Copy link
Owner Author

skmp commented Aug 7, 2018

@dmiller423 pretty pls can you avoid pushing to master and other such over-the-top commit approaches? You have full admin rights to the repo (it's you, me and @MrPsyMan atm) and you have a lota power to break things 🥇

Closing this as master is now working again :)

@skmp skmp closed this as completed Aug 7, 2018
This was referenced Aug 7, 2018
Closed
Closed
@skmp skmp changed the title Broken master Broken master / Beta builds not from master Aug 7, 2018
@skmp skmp reopened this Aug 7, 2018
@skmp
Copy link
Owner Author

skmp commented Aug 7, 2018

Looks like this issue is more complicated. Somehow builds with non-matching commits make it to google play (?)

@skmp skmp added the important label Aug 7, 2018
@dmiller423
Copy link
Contributor

...

@skmp
Copy link
Owner Author

skmp commented Aug 7, 2018

Yeah, looks like you can't take the blame for this one, @dmiller423. The builds must have been broken by the tag change? How did that happen?

@AbandonedCart it looks like ./travis-deploy.sh is not getting run during master builds now

@dmiller423
Copy link
Contributor

@skmp : @AbandonedCart mentioned some issues w. travis and I knew that code shouldn't have possibly broken the emulator. If it works on most of the platforms and not on one, you know the bug lies elsewhere 99% of the time.

@AbandonedCart
Copy link
Contributor

Both the commit and wonky travis builds have been fixed. The desired changes can now be tested against a verified working master.

@skmp skmp added the important label Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skmp @dmiller423 @AbandonedCart