New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
predef option is passed to jslint as string #10
Comments
@nikuda thanks for tip, I wasn't aware of that. What's funny that this issue was "fixed" in For some reason this issue haven't been closed. I'm doing it now.. |
@medikoo The fix you mention above hasn't worked for me, and I'm not entirely sure it would work for anyone else. It seems that nopt gets to parsing the options before the fix code does. Because nopt parses the options first, anything after the first comma ends up in the parsed.argv.remain array, which gets passed to lintFile() which then fails. |
@nikuda indeed, I looked at the code and such support was broken few months ago with that commit: 7fd0321#bin/jslint.js Anyway now it's probably more up to |
Not a problem, thanks. I can also remove the dead code as part of my pull request above, if you don't see any other potential problems. |
@nikuda it's no problem. I'm anyway not using that branch anymore (I had some specific needs and I'm now using different version of |
predef option when passed to jslint should be instance of Array or Object, but currently it is passed as it was read from command line - as string, which makes it unusable as jslint then just ignores its value.
It'll be great to have it parsed into an array before it goes to jslint.
The text was updated successfully, but these errors were encountered: