Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose-filter assumes too much? #33

Closed
gfredericks opened this issue Nov 5, 2013 · 3 comments
Closed

rose-filter assumes too much? #33

gfredericks opened this issue Nov 5, 2013 · 3 comments

Comments

@gfredericks
Copy link
Contributor

rose-filter assumes that if a node doesn't pass the predicate, none of its children will.

@reiddraper
Copy link
Owner

I've tried to fix this a couple of times, but it's non-obvious to me what to do to exclude a node from the tree. Do you just replace the node with all of it's children, and then work recursively?

@gfredericks
Copy link
Contributor Author

Could you promote the first child to the root and concat its children to the rest of the children?

@reiddraper
Copy link
Owner

Moved to Jira.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants