Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCA: biplot #21

Closed
essicolo opened this issue Mar 2, 2017 · 2 comments
Closed

PCA: biplot #21

essicolo opened this issue Mar 2, 2017 · 2 comments
Labels
enhancement

Comments

@essicolo
Copy link

essicolo commented Mar 2, 2017 •
edited

The plot_pca_2d_projection method plots scores and colors by target. Biplots usually plot the scores and vectors with different scalings (scaling 1: distance, and scaling 2: correlation): biplots could included in plot_pca_2d_projection or as separate method. The target argument would preferably be optional. The ecopy library includes a nice biplot interface.
@reiinakano
Copy link
Owner

reiinakano commented Mar 2, 2017 •
edited

Hi @essicolo ! I have to admit this is the first time I've heard of biplots. After a bit of reading, they seem like they would make a great addition to the plot_pca_2d_projection function.

While I'll try to work this out when I have free time, feel free to contribute a PR. 👍 Thanks for the suggestion!

@ryanliwag ryanliwag mentioned this issue Jan 4, 2018
Merged
@reiinakano
Copy link
Owner

After months, this issue can finally be closed thanks to @ryanliwag and #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@essicolo @reiinakano