Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ValueTuple #47

Closed
chris-cartwright opened this issue Aug 30, 2017 · 3 comments
Closed

Support ValueTuple #47

chris-cartwright opened this issue Aug 30, 2017 · 3 comments
Assignees
@pavel-b-novikov

Comments

@chris-cartwright
Copy link

Reinforced.Typings.TypeExtensions.IsTuple doesn't check for System.ValueTuple and returns false, causing all ValueTuples to map to any. Can support for ValueTuple be added?
@pavel-b-novikov pavel-b-novikov self-assigned this Aug 30, 2017
@pavel-b-novikov
Copy link
Member

Will be added in further release

@chris-cartwright
Copy link
Author

It would also be nice if Reinforced.Typings used the ValueTuple's item names to generate an object instead of using TypeScript's tuples. Some quick searching found TupleElementNamesAttribute: https://stackoverflow.com/a/43489034

@pavel-b-novikov
Copy link
Member

Please implement feature above by yourself using inline type inferers or substitutions. By default RT will convert ValueTuple to TS tuple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-b-novikov pavel-b-novikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavel-b-novikov @chris-cartwright