Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/fix basic tests for wxqt #5

Closed
reingart opened this issue May 19, 2014 · 1 comment
Closed

add/fix basic tests for wxqt #5

reingart opened this issue May 19, 2014 · 1 comment

Comments

@reingart
Copy link
Owner

Testing the Controls' sample, runtime checks and assertions would be added to assure that fixes are working correctly.
Also, I'll like to review the code to avoid memory leaks / qt signal disconnection issues on destruction (due new syntax), and polish any eventual codding issue (including refactor to qt thin and simplified helpers, see 51da1ea and 7aa4fad).
Finnally, I'll focus on add/update comments and documentation

@reingart reingart added this to the wxQT enhancements milestone May 19, 2014
@reingart reingart assigned reingart and unassigned reingart May 19, 2014
@reingart
Copy link
Owner Author

Controls sample is working and functional, removed pending issues and improved control support (IMHO wxQT could be used to develop simple applications now).

Summary:

  • Made qt helpers internal and thin (almost no trivial methods)
  • Fixed calendar control
  • Fixed check list control
  • Completed minimal implementation of text control
  • Refactorized combobox and buttons
  • Fixed notebook events (better implementation)
  • Fixed SIGSEGV on paint event
  • Template helper moved to private header
  • Revised prior commits (ie new wxGA_TEXT style)
  • Added and fixed slider ticks
  • Minor fixes and improvements

After some investigation, qt signal disconnection should not pose any problem as wxQT is not using lambdas (and signals are automatically disconected when object are destroyed, and it is not using cross signal/slot object connections: qt helpers are thin and connect they own signals inside to their own methods).
Some asserts and checks where introduced to controls sample, but it is not wise to keep adding stuff there, it would be better to fix tests.

New issues open for future milestones (almost all are previous topics not introduced in this gsoc):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant