Install failed test: Expected a combining operator like '-a' at index 2

[mrichman]

fisher install reitzig/sdkman-for-fish@v2.1.0
fisher install version 4.4.4
Fetching https://api.github.com/repos/reitzig/sdkman-for-fish/tarball/v2.1.0
Installing reitzig/sdkman-for-fish@v2.1.0
           /Users/mark/.config/fish/functions/sdk.fish
           /Users/mark/.config/fish/conf.d/sdk.fish
           /Users/mark/.config/fish/completions/sdk.fish
test: Expected a combining operator like '-a' at index 2
                           != mark
 ^
~/.config/fish/conf.d/sdk.fish (line 99):
if not set -q SDKMAN_CANDIDATES_DIR; or test (ls -ld "$SDKMAN_CANDIDATES_DIR" | awk '{print $3}') != (whoami)
                                        ^
from sourcing file ~/.config/fish/conf.d/sdk.fish
	called on line 189 of file ~/.config/fish/functions/fisher.fish
in function 'fisher' with arguments 'install reitzig/sdkman-for-fish@v2.1.0'
Updated 1 plugin/s

[reitzig]

fish --version
cat /etc/os-release

?

[mrichman]

4.4.4
macOS 14.5

uninstall and reinstall seems to have fixed it

[reitzig]

Huh, that's odd. 🤔

I may have to keep an eye out for changes in fish.

[mrichman]

@reitzig Just got it again on a different machine:

fisher install reitzig/sdkman-for-fish@v2.1.0
fisher install version 4.4.4
Fetching https://api.github.com/repos/reitzig/sdkman-for-fish/tarball/HEAD
Installing reitzig/sdkman-for-fish
           /Users/mark/.config/fish/functions/sdk.fish
           /Users/mark/.config/fish/conf.d/sdk.fish
           /Users/mark/.config/fish/completions/sdk.fish
test: Expected a combining operator like '-a' at index 2
   != mark
 ^
~/.config/fish/conf.d/sdk.fish (line 99):
if not set -q SDKMAN_CANDIDATES_DIR; or test (ls -ld "$SDKMAN_CANDIDATES_DIR" | awk '{print $3}') != (whoami)
                                        ^
from sourcing file ~/.config/fish/conf.d/sdk.fish
	called on line 189 of file ~/.config/fish/functions/fisher.fish
in function 'fisher' with arguments 'install reitzig/sdkman-for-fish'
Installed 1 plugin/s

Fisher 4.4.4
Fish 3.7.1

fisher list

oh-my-fish/plugin-osx
jorgebucaran/nvm.fish
reitzig/sdkman-for-fish@v2.1.0

macOS 13.6.7

[reitzig]

Can't reproduce on CI with these exact versions: github.com/reitzig/sdkman-for-fish/actions/runs/9735550696

Say, do you have a non-standard test for some reason? 🤔

[mrichman]

Don't think so, but I'm on macOS so it might behave differently. When I install on Linux I have no issues.

[mrichman]

I figured it out. I had ls aliased to eza on macOS. Removing that solved the problem. Sorry for the trouble!

[reitzig]

You'll notice that the tests run on macOS as well, and are green.

Without a way to reproduce I won't be able to investigate; don't have a Mac here myself, so it'll have to be in the workflow. Can you provide a failing test?

[reitzig]

Ah. Yet another instance of #23, then. 🤔 Re-assigning GNU-tool names seems to become more common, for better or worse; may have to look at that issue, after all.