New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 1125 - BodyParam were broken with default values #1129
Conversation
Looks good. New DUB release is needed to get rid of that error. |
Fix issue 1125 - BodyParam were broken with default values
Thanks !
Any ETA ? Also any plan for a Vibe.d release ? |
I would like to wait for dlang/dub#582 to get reviewed/merged, but if that doesn't happen in the near term, I'd just start the release process based on the current status (there are mostly only bug fixes since 0.9.23). The next vibe.d release should again happen in sync with DMD 2.068. The only thing I still want to review/finish is the start of the transition to using |
Again many unmerged changes on my fork, I tested everything 1 million times, for leaks as well. Seems good now. A new Task debugging feature is there as well on etcimon@d8006c2#diff-ab96042d1071a2f6d25b2d780277a06bR37 See screenshot: http://i.imgur.com/vpVcDnN.jpg |
As a side note, I wrote this at first as a tool to find leaks, but I found it to be a nice solution for many other things because the link time in Windows is absolutely horrible in etcimon@1951cf2#diff-5a483448dcc1a27cb132021d682e1d1bR279 I think the debugger could gradually become a sort of process manager with debug information, I intend on making a nice GUI javascript framework for it. |
@s-ludwig : A release of dub soonish would be awesome, because until then, vibe.d master will be red, and that kinda defeat the purpose of CI :) |
We can add a quick workaround to travis.yml in the meantime (first do @etcimon I actually have a graphical debugger in the works (didn't have time to work on it since a while though). We should definitely try to at least avoid duplicate work here. |
Turns out that the package description of the new test was actually wrong. Should hopefully go green now. |
It shouldn't be duplicate work, I didn't know you did that btw. My problem is, I currently find it very hard to write and debug new pages because of all the side effects involved in a complex web application. I get 16mb logs for a few requests, so I'm working on a fiber filtering logging feature. I also don't really have any way to know if fibers have hung or where they hung. It's also a pain to build with symbols all the time the windows linker starts over because of it. So I actually want to make it a JSON API sort of "task process manager", I have the memory usage per task now, and I can "interrupt" hung tasks and see where they hung even on release builds. The most important feature for me is the "Recording with filters" feature I'm working on right now. It's a little tiring to have to use log files for each task indiscriminately to examine one little thing e.g. When you request: The page will simply wait for a request to If trace was specified, the I think the two tools can actually be merged in some way since this will be an API. |
The API level (and below) is where I expected the duplication to happen. What I have is a small library that hooks into the vibe.d application using the If that would be interesting for you, I could make this part of the project public. It's just a smallish 300 loc library plus the stack trace code. |
I have no idea how it used to compile...