Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP 800-53 RES should not resolved at all because the PubID is incorrect #87

Open
ronaldtse opened this issue Mar 29, 2023 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

This entry should not resolve:

* [[[SP_800_53_RES,SP 800-53 RES]]], NIST Special Publication 800-53, Revision 5 Resource Center.
https://csrc.nist.gov/publications/detail/sp/800-53/rev-5/final

Output:

[relaton-nist] ("NIST SP 800-53 RES") fetching...
[relaton-nist] ("NIST SP 800-53 RES") found SP 800-53 Rev. 5

Issue from https://github.com/metanorma/mn-samples-nist/pull/79

@ronaldtse ronaldtse added the bug Something isn't working label Mar 29, 2023
@andrew2net
Copy link
Contributor

@ronaldtse in the relaton-nist we compare parts of a reference against parts of docuements' IDs. The "RES" doesn't fall into any parts, so it is ignored.
Also, the comparation is not strict now. I.e. if reference doesn't have a revision, we don't check if an ID has it.
I suggest to make the comparation more strict, so the parts volume, version, and revision will be alway cheched. So the "NIST SP 800-53 RES" reference will return "SP 800-53".
We can't consider the "RES" or other unexpected string in references without rewriting reference's and ID's parsers. If we will see the pubid-nist soon, which will do all the parsing jobs, then it doesn't worth to spend time on rewriting the parsers.
Do you agree with my suggestion?

@ronaldtse
Copy link
Contributor Author

Yes I agree with relying on pubid-nist for parsing.

@andrew2net
Copy link
Contributor

fixed in v 1.14.5

$ relaton fetch "NIST SP 800-53 RES"
[relaton-nist] ("NIST SP 800-53 RES") fetching...
[relaton-nist] ("NIST SP 800-53 RES") found SP 800-53
<bibdata type="standard" schema-version="v1.2.3">
  <fetched>2023-06-05</fetched>
  <title format="text/plain" language="en" script="Latn">Recommended Security Controls for Federal Information Systems </title>
  <uri type="src">https://csrc.nist.gov/publications/detail/sp/800-53/archive/2005-06-17</uri>
  <uri type="doi">https://doi.org/10.6028/NIST.SP.800-53</uri>
  <docidentifier type="NIST" primary="true">SP 800-53</docidentifier>
  <docidentifier type="DOI">NIST.SP.800-53</docidentifier>
  ...

@ronaldtse ronaldtse reopened this Aug 21, 2023
@ronaldtse
Copy link
Contributor Author

ronaldtse commented Aug 21, 2023

@andrew2net there is a misunderstanding here.

This behavior is wrong:

$ relaton fetch "NIST SP 800-53 RES"
[relaton-nist] ("NIST SP 800-53 RES") fetching...
[relaton-nist] ("NIST SP 800-53 RES") found SP 800-53
<bibdata type="standard" schema-version="v1.2.3">

This item should not resolve. i.e. it should return not found.

It should not resolve to:

  • SP 800-53r5
  • SP 800-53 series

It should NOT resolve because the PubID is incorrect / not a PubID.

@ronaldtse ronaldtse changed the title SP 800-53 RES should not be resolved to SP 800-53 Rev. 5 SP 800-53 RES should not resolved at all because the PubID is incorrect Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants