New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo delivery: Subsequent cargoes may not be delivered if the iterable isn't quick enough #243

Open

gnarea opened this issue Aug 20, 2021 · 1 comment

Labels

bug

Projects

Member

gnarea commented Aug 20, 2021

We're currently ending the connection when all deliveries have been acknowledged, without checking if all cargoes were sent:

relaynet-cogrpc-js/src/lib/client.ts

Lines 108 to 110 in 121baaf

    
           if (Object.getOwnPropertyNames(pendingAckIds).length === 0) { 
        
             break; 
        
           }

gnarea added the bug label

gnarea added this to To do in Maintenance via automation

Member Author

gnarea commented Dec 8, 2021

See https://github.com/relaycorp/it-duplex-ack-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment