New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore TLS authentication and move to a one-team-per-connection model #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchambers
force-pushed
the
restore_tls_authentication
branch
from
April 17, 2017 13:36
a1854eb
to
c2f99dc
Compare
jchambers
force-pushed
the
restore_tls_authentication
branch
from
April 25, 2017 23:03
81e4b69
to
b026e7d
Compare
jchambers
force-pushed
the
restore_tls_authentication
branch
4 times, most recently
from
May 3, 2017 22:27
d56de4e
to
a0eec08
Compare
jchambers
force-pushed
the
restore_tls_authentication
branch
from
May 3, 2017 22:43
a0eec08
to
72120cc
Compare
This was referenced May 3, 2017
Closed
This was referenced May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently learned that the APNs server enforces a "one team per connection" rule, which has led us to make two big changes:
There's a lot of stuff in here, but a lot of it is just un-deleting files and also importing work from the "move stuff into the handler instead of the client" effort (see #404). At the end of the day, I think this makes a lot of things a lot cleaner, but boy howdy is there a lot going on here. Feedback is greatly appreciated!
TODO:
ApnsClient
andApnsClientBuilder
)ApnsSigningKey
andApnsVerificationKey