Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore TLS authentication and move to a one-team-per-connection model #451

Merged
merged 21 commits into from May 3, 2017

Conversation

jchambers
Copy link
Owner

@jchambers jchambers commented Apr 17, 2017

We recently learned that the APNs server enforces a "one team per connection" rule, which has led us to make two big changes:

  1. TLS authentication is now back to stay.
  2. We've adjusted a lot of internals and public interfaces to better reflect the "one team per connection" rule.

There's a lot of stuff in here, but a lot of it is just un-deleting files and also importing work from the "move stuff into the handler instead of the client" effort (see #404). At the end of the day, I think this makes a lot of things a lot cleaner, but boy howdy is there a lot going on here. Feedback is greatly appreciated!


TODO:

  • Update README
  • Update documentation (especially ApnsClient and ApnsClientBuilder)
  • Add tests for ApnsSigningKey and ApnsVerificationKey

@jchambers jchambers added this to the v0.10 milestone Apr 17, 2017
@jchambers jchambers force-pushed the restore_tls_authentication branch 4 times, most recently from d56de4e to a0eec08 Compare May 3, 2017 22:27
@jchambers jchambers force-pushed the restore_tls_authentication branch from a0eec08 to 72120cc Compare May 3, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant