-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle / warn about API rate limits? #1018
Comments
with over 36k commits drafting a release could several minutes if not hours. 😅 The docs are pretty bloated already, who reads them. Sometimes I doubt anybody does. Good luck finding a mention of BTW we use actual APIs to figure stuff out that could be dependent on rate limits. Ya we should properly handle rate limits 😅 Though never had a need for it. See https://github.com/release-drafter/release-drafter/blob/master/lib/pagination.js We are using probot which should have throttling in place: |
Totally not suggesting it should handle the 36k case, just that the reason for failure wasn't immediately obvious ;) |
Also hit this when trying to convert a large monorepo that does a single monolithic release to doing individual releases per service within the monorepo. Repo has hundreds of thousands of commits and many tags and releases. Just that none of the existing releases match the new per service tag prefixes so it;s trying to create first release for each service that covers the entire repo hisdtory. Maybe simple option would be to add something like |
Allowing to specify a limit to the number of commits fetched would also be acceptable for me. My project's history is many years old, but releases are never going to be > ~1000 commits apart. |
I also ran into this issue. Is there a workaround? I created a dummy draft release but I'm not sure how to make release-drafter only fetch commits starting from that point. Update: I got it working 🎉 . The release has to be published and not in draft. |
I'm having a similar problem: I'm trying to create several draft releases from the same repository but I'm being throttled
that wouldn't be an issue per se, but the job step is not failing, so I don't have any other choice than re-trying all the releases instead of only the ones that failed. |
were you able to resolve your issue? I am facing a similar issue while trying to automate multiple draft-release using |
I found that this situation happened when there were no previous release for said components, making the action navigate the whole repo history. Thus I "fixed" it by creating an initial release manually. |
So I tried adding release-drafter to an existing repository with over ~36k commits and not a single tag or release and that didn't go that well. Apparently it tried to fetch all of those ~36k commits via the GraphQL API, hit the limits and failed.
First run
Second and subsequent runs
What also seems wrong is that the job is green in the end, and the rate limits errors are presented merely as annotations:
Screenshot
In the end I got it to run successfuly by creating a dummy v0 release, making release-drafter only fetch commits starting from that point.
So my thoughts are:
The text was updated successfully, but these errors were encountered: