Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-semver releases #9

Closed
toolmantim opened this issue Jul 10, 2018 · 4 comments
Closed

Support non-semver releases #9

toolmantim opened this issue Jul 10, 2018 · 4 comments
Labels
type: feature New feature or request

Comments

@toolmantim
Copy link
Collaborator

Currently if you try to use Release Drafter on a repo that has non-semver compatible release names, it throws Error: Invalid argument not valid semver when compare-versions is used.

We should perhaps just compare the dates of the two releases in this case, and assume the more recent release is greater?

@toolmantim
Copy link
Collaborator Author

@balloob this is why it's currently not working on https://github.com/home-assistant/home-assistant-polymer/releases

@toolmantim toolmantim added the type: feature New feature or request label Jul 10, 2018
@balloob
Copy link
Contributor

balloob commented Jul 11, 2018

Maybe it could be an option ? semver: false. I can see how for projects with semver that have multiple active releases (like Node, example 6.X and 8.X), just picking the last one will not work.

@toolmantim
Copy link
Collaborator Author

Ah, multiple release tracks might be something else altogether though, but still a neat feature. For Node, right now it works but it'd only track the v10 releases, because it just asks "what's merged to master since the release with the highest semver version number?"

I'll get non-semver releases working to start. Multiple release paths can come later when people need.

@toolmantim
Copy link
Collaborator Author

Fixed in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants