New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn Nexus cleanup task #343
Add yarn Nexus cleanup task #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some unit tests to cover this change?
It would be similar. That "magic number" is just a fake request ID (and also the answer to the ultimate question of life, the universe, and everything) |
Many people have speculated that if we knew exactly why the test had been written like that we would know a lot more about the nature of the Universe than we do now. |
e299cbf
to
2dce90f
Compare
@athos-ribeiro Ok, there is a new unit test. But looks like something is fundamentally wrong with the universe and the test coverage is broken for me locally:
|
Could that be that you are running just one specific test instead of the test suite? Travis reposts 100% coverage there: However, tests are failing:
|
Remove temporary Nexus data for stale or failed requests that uses "yarn" as package manager.
2dce90f
to
075b424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
LGTM
Remove temporary Nexus data for stale or
failed requests that uses "yarn" as package manager.
I am not really sure how to add a unit test, because for pip we have a magic number 42 there