Add origin_response lambda function

[crungehottman]

The cache_control function appends a "Cache-Control: max_age=600" header to HTTP responses from the origin server.

Resolves: DELIVERY-8986

[rohanpm]

I don't think it should be named cache_control, should it? Because we expect that we will need to add some more behaviors onto origin-response events, and we'll need all of that to be handled by one lambda function, so we would end up with a function named cache_control which is actually doing a bunch more.

Actually, the internal name doesn't matter much, but could we please have an entry for the function in cdn_lambda/__init__.py named origin_response to match the existing origin_request?

[negillett]

@rohanpm, @crungehottman, I wouldn't be opposed to naming the function "origin_response" and changing "map_to_s3" to "origin_request". I don't foresee swapping out request or response functions on our distributions, but rather adding functionality to the existing functions as needed.

[crungehottman]

note: black reformatted this line

[crungehottman]

I'm a regex newbie -- I don't think this pattern is optimal, but it works. Feel free to suggest a more optimal regex.

[rohanpm]

I think this will break "tox -e package" because the config file path is written there (in tox.ini), could you please have a look?

I'm not sure how you generate your deployment packages right now during development but you should maybe look into using that command if you aren't already, ideally we are all using the same method to make a deployment package so we will find the same issues.

CI also really ought to be testing that tox command, I'll make a separate PR for that.

[crungehottman]

I think this will break "tox -e package" because the config file path is written there (in tox.ini), could you please have a look?

It did break tox - e package. I updated the path to the config file in tox.ini and now tox -e package is passing.

I'm not sure how you generate your deployment packages right now during development but you should maybe look into using that command if you aren't already, ideally we are all using the same method to make a deployment package so we will find the same issues.

I have not been generating deployment packages, but I will be sure to include tox -e package in my development workflow.

CI also really ought to be testing that tox command, I'll make a separate PR for that.

Thanks!

[rohanpm]

github says there are conflicts, would you mind fixing those too for the next round of review?

[rohanpm]

Looks fine to me.

There are still conflicts though. I'll resolve them on your behalf later if needed.

[rohanpm]

Resolved the conflicts. I'll submit this for you now so it lands prior to repo rename.