Skip to content

Commit

Permalink
Wrong input filed name will not be updated.
Browse files Browse the repository at this point in the history
JIRA: PDC-1099
  • Loading branch information
simozhan committed Oct 20, 2015
1 parent 20b0a63 commit 8249277
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pdc/apps/osbs/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@
#
from rest_framework import serializers

from pdc.apps.common.serializers import StrictSerializerMixin
from pdc.apps.component import serializers as component_serializers
from . import models


class OSBSSerializer(serializers.ModelSerializer):
class OSBSSerializer(StrictSerializerMixin,
serializers.ModelSerializer):
component = component_serializers.ReleaseComponentField(
read_only=True
)
Expand Down
14 changes: 14 additions & 0 deletions pdc/apps/osbs/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,17 @@ def test_cloning_release_clones_osbs(self):
self.assertTrue(records.get(component__name='python27').autorebuild)
self.assertFalse(records.get(component__name='MySQL-python').autorebuild)
self.assertNumChanges([6]) # 1 release, 3 components, 2 osbs records

def test_update_with_wrong_key(self):
response = self.client.put(reverse('osbs-detail', args=['release-1.0/python27']),
{'autorebuild': False, 'wrongkey': True},
format='json')
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
self.assertEqual(response.data, {"detail": 'Unknown fields: "wrongkey".'})

def test_partial_update_with_wrong_key(self):
response = self.client.patch(reverse('osbs-detail', args=['release-1.0/python27']),
{'wrongkey': False},
format='json')
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
self.assertEqual(response.data, {"detail": 'Unknown fields: "wrongkey".'})

0 comments on commit 8249277

Please sign in to comment.