Skip to content

Commit

Permalink
Fix bulk operations tests.
Browse files Browse the repository at this point in the history
When use mock(v1.3.0), there is no `assert_called` for Mock object,
update three tests to make them pass.
  • Loading branch information
xychu committed Aug 11, 2015
1 parent e0795d5 commit dc00cfa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions contrib/bulk_operations/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def view(viewset, _request, **kwargs):
self.request.data = ['foo', 'bar', 'baz', 'quux']
with mock.patch('logging.getLogger') as getLogger:
response = wrapped(self.viewset, self.request)
getLogger.return_value.assert_called()
self.assertTrue(getLogger.return_value.error.called)
self.assertEqual(response.status_code, status.HTTP_503_SERVICE_UNAVAILABLE)

def test_create_wrapper_aborts_on_bad_response(self):
Expand Down Expand Up @@ -100,7 +100,7 @@ def view(viewset, _request, **kwargs):
self.request.data = ['foo', 'bar', 'baz', 'quux']
with mock.patch('logging.getLogger') as getLogger:
response = bulk.bulk_destroy_impl(self.viewset, self.request)
getLogger.return_value.assert_called()
self.assertTrue(getLogger.return_value.error.called)
self.assertEqual(response.status_code, status.HTTP_503_SERVICE_UNAVAILABLE)

def test_bulk_destroy_aborts_on_bad_response(self):
Expand Down Expand Up @@ -155,7 +155,7 @@ def view(viewset, _request, **kwargs):
self.request.data = {'foo': {'key': 'val1'}, 'bar': {'key': 'val2'}, 'baz': {'key': 'val3'}}
with mock.patch('logging.getLogger') as getLogger:
response = bulk.bulk_update_impl(self.viewset, self.request)
getLogger.return_value.assert_called()
self.assertTrue(getLogger.return_value.error.called)
self.assertEqual(response.status_code, status.HTTP_503_SERVICE_UNAVAILABLE)

def test_bulk_update_aborts_on_bad_response(self):
Expand Down

0 comments on commit dc00cfa

Please sign in to comment.