Rename resource names #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
I think it would be nice to change the router |
|
@lubomir Very nice proposal. Since the deprecated end-point will be remove in future. I did not think about more. |
To be consistent with other end-points, rename below three ones: * content-delivery-content-category -> content-delivery-content-categories * content-delivery-content-format -> content-delivery-content-formats * content-delivery-service -> content-delivery-services * persons -> contacts/people * maillists -> contacts/mailing-lists The old names remain available for backwards compatibility, but has been marked deprecated. JIRA: PDC-1027
erichuanggit
force-pushed
the
PDC-1027_Rename-resource-names
branch
from
cdc110b
to
2940d01
Compare
|
Looks fine. |
|
@lubomir Thanks. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with other end-points, rename below three ones:
The old names remain available for backwards compatibility, but has been
marked deprecated.
JIRA: PDC-1027