Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use popovers instead of dialogs for help #199

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Conversation

lubomir
Copy link
Member

@lubomir lubomir commented Nov 4, 2015

The popovers are triggered by hovering over the icon. Once the cursor
leaves the icon, the popover is hidden. The only exception is if the
cursor moved over the actual popover, in which case it will disappear
only after the cursor left it.

JIRA: PDC-1115

@erichuanggit
Copy link
Collaborator

Except for that the font size is too big in the tooltip, other looks good to me.

@lubomir
Copy link
Member Author

lubomir commented Nov 6, 2015

@erichuanggit It uses same font size as the rest of the web ui. Maybe UX team can help with the design.

@erichuanggit
Copy link
Collaborator

As talked to UX team, they also suggest making the font smaller in the tooltip. Below is what we tried together in my local:

.popover-content{
    font-size:12px;
}

@xychu
Copy link
Contributor

xychu commented Nov 11, 2015

Looks good to me.

The popovers are triggered by hovering over the icon. Once the cursor
leaves the icon, the popover is hidden. The only exception is if the
cursor moved over the actual popover, in which case it will disappear
only after the cursor left it.

JIRA: PDC-1115
@lubomir lubomir merged commit 05280ef into master Nov 12, 2015
@lubomir lubomir deleted the pdc-1115-help-popover branch November 12, 2015 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants