pdc command take release and name as parameters instead of id. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
The output of a exception looks not so friendly for user. How about print the error message and exit(1). Could it report the error by exiting code? |
|
Printing the error and exitting would work as well. My main complaint is that the exit code should not be 0. |
ycheng-aa
force-pushed
the
PDC-1159_client_release_component_update
branch
2 times, most recently
from
d58ab45
to
6ec085d
Compare
|
Rebase to eliminate CI failed. |
|
Looks good to me. |
|
👍 |
ycheng-aa
force-pushed
the
PDC-1159_client_release_component_update
branch
from
eda6133
to
63152c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: PDC-1159