Add new endpoint API ComposeTree #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| -d _data_ (a json string). or GUI plugins for | ||
| browsers, such as ``RESTClient``, ``RESTConsole``. | ||
| """ | ||
| queryset = ComposeTree.objects.all() |
There was a problem hiding this comment.
If some other related objects also need to be accessed, maybe could use select_related() to fetch them with on DB hit.
|
Generally looks good to me. |
| class ComposeTree(models.Model): | ||
| compose = models.ForeignKey("Compose") | ||
| variant = models.ForeignKey("Variant") | ||
| arch = models.CharField(max_length=50) |
There was a problem hiding this comment.
I think these should be one of currently defined arches and not just any string.
|
Looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: PDC-1100