Log exception when 503 is returned #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
This should help with troubleshooting problems on devel or qa servers as the traceback will be in server error log. There is a change in bulk ops test suite. Some of the tests were actually wrong and raised an exception for a wrong reason. All exception logging in those tests is silenced. This can help development since if there is an unhandled exception causing 503, the tests now show a traceback of the error instead of just the failed assertion. There is no change when looking at the bad page in browser.
lubomir
force-pushed
the
pdc-915-log-exceptions
branch
from
6735ea7
to
4a81b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with troubleshooting problems on devel or qa servers as
the traceback will be in server error log.
There is a change in bulk ops test suite. Some of the tests were
actually wrong and raised an exception for a wrong reason. All exception
logging in those tests is silenced.
This can help development since if there is an unhandled exception
causing 503, the tests now show a traceback of the error instead of just
the failed assertion. There is no change when looking at the bad page in
browser.