Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog not committed back into repo #67

Closed
Ardesco opened this issue Feb 1, 2024 · 2 comments
Closed

Updated changelog not committed back into repo #67

Ardesco opened this issue Feb 1, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@Ardesco
Copy link

Ardesco commented Feb 1, 2024

Not sure what I'm missing here but the CHANGELOG.md doesn't seem to get comitted back into my repo. The release I'm tagging has the correct version and release notes so I'm not sure what I'm missing here, does this action just not commit back?

@richtea richtea added the question Further information is requested label Feb 2, 2024
@richtea richtea self-assigned this Feb 2, 2024
@richtea
Copy link
Contributor

richtea commented Feb 2, 2024

Hi @Ardesco thanks for trying out this action. You're quite right, the action doesn't commit, it just edits the changelog on disk. You need to add another step to your workflow to commit the changes. I'm a big fan of the Unix philosophy "Write programs that do one thing and do it well".

I've got an example workflow here that runs this action followed by another action that creates a PR for the changelog updates - it's a little out of date because the core github actions are on a downlevel version, but it shows the basic principles. Or you could commit and push within your workflow - this article describes a few ways to do that.

@Ardesco
Copy link
Author

Ardesco commented Feb 2, 2024

That makes sense. Would be useful to make that clear on the documentation as I spent a while trying to work out what was wrong with my config for the bump command before I raised this, so I'm hoping I'm not the only one... :)

@Ardesco Ardesco closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants