Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipUnstable does nothing #12

Closed
jsamr opened this issue Aug 20, 2020 · 3 comments
Closed

skipUnstable does nothing #12

jsamr opened this issue Aug 20, 2020 · 3 comments

Comments

@jsamr
Copy link

jsamr commented Aug 20, 2020

First of all, thanks a lot for this great library! The README.md states (emphasis mine):

Options are passed verbatim to conventional-recommended-bump and conventional-changelog.

However, changelog is still produced for pre-releases (tested with rc and alpha). This is the relevant part of my package.json

  "release-it": {
    "git": {
      "commitMessage": "chore: release ${version}",
      "tagName": "v${version}"
    },
    "npm": {
      "publish": true
    },
    "github": {
      "release": true
    },
    "plugins": {
      "@release-it/conventional-changelog": {
        "preset": "angular",
        "infile": "CHANGELOG.MD",
        "skipUnstable": true
      }
    }
  }

The option is documented here. Result:
2020-08-20-150851_652x290_scrot

Please note that release-it is not a global install, but an alias to npx release-it

@webpro
Copy link
Contributor

webpro commented Oct 11, 2020

Hmm I would think the options would end up as first argument for conventionalChangelogCore(options). Maybe you can run a DEBUG=release-it:* release-it [...] run, this should give more output and also pass the debug option to conventional-changelog.

@jsamr
Copy link
Author

jsamr commented Oct 11, 2020

@webpro After a little lookup, I think the issue is upstream: conventional-changelog/conventional-changelog#675

@webpro
Copy link
Contributor

webpro commented Jun 6, 2021

Closing this issue, as the issue is likely upstream. Feel free to re-open or raise another issue.

@webpro webpro closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants