Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver is not declared in dependencies #49

Closed
cravend opened this issue Jun 9, 2022 · 4 comments
Closed

Semver is not declared in dependencies #49

cravend opened this issue Jun 9, 2022 · 4 comments

Comments

@cravend
Copy link

cravend commented Jun 9, 2022

Hi y'all!

I'm trying to use this with Yarn berry, but I'm running into an issue:

ERROR @release-it/conventional-changelog tried to access semver, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: semver (via "semver/package.json")
Required by: @release-it/conventional-changelog@virtual:f8628a01fc8a0c88efe1afe17f2bd962a545e2644e7bc646f13ee6114785601dea0fc25e5105597cdbff6bdbc249a1f8dc91aaafa859915fd961e5dec7c0ab9f#npm:5.0.0 (via /Users/cravend/src/html/object-access/.yarn/__virtual__/@release-it-conventional-changelog-virtual-9949b6766b/0/cache/@release-it-conventional-changelog-npm-5.0.0-19f49b5e03-205a743018.zip/node_modules/@release-it/conventional-changelog/index.js)

Is there any reason semver shouldn't be included in the dependencies array?

@Jungho-Cheon
Copy link

same issue here.

are you using yarn berry with pnp?

@webpro
Copy link
Contributor

webpro commented Aug 17, 2022

Yarn Berry is not officially supported by release-it (it uses npm not Yarn to version and publish). Things may or may not work depending on local workflow and config etc.

Feel free to open a PR with improvements, though, happy to discuss and look into it.

@webpro
Copy link
Contributor

webpro commented Aug 17, 2022

Oh wait, sorry, yes semver should definitely be a dependency. Will fix this shortly!

@webpro webpro closed this as completed in d039a1c Aug 17, 2022
@webpro
Copy link
Contributor

webpro commented Aug 17, 2022

This is in v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants