Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when including; "private: true' in execute, release hangs upon finishing #18

Closed
takotuesday opened this issue Apr 22, 2015 · 2 comments
Closed

Comments

@takotuesday
Copy link

Here is my release.execute call:

                release.execute({
                    buildCommand:   'npm install && npm run build && npm run ',
                    commitMessage:  'chore(release): v%s',
                    increment:      version,
                    pkgFiles:       'package.json',
                    private:        true,
                    tagAnnotation:  'Release v%s',
                    tagName:        'v%s',
                    verbose:        true
                }).finally(done);
            });

After running release, I am able to publish to git, and as expected I am not prompted to publish to npm. The problem is however, that the task hangs after 'Finished' and I must hit enter to end the procress. This doesnt happen when 'private' is not passed as an argument to execute.

[execute] git tag  --annotate --message="Release v4.0.8" v4.0.8
[?] Push? No
No Git endpoint provided for `distRepo` (distribution repository).
[16:35:27] Finished 'release' after 28 s
@webpro
Copy link
Collaborator

webpro commented Apr 23, 2015

The first thing that comes to mind is that you probably need to exit the process in Node. See the CLI script: https://github.com/webpro/release-it/blob/master/bin/release.js. Are you handling this in your done function? E.g.:

release.execute({}).then(function() {
    process.exit(0);
}, function(error) {
    console.error(error);
    process.exit(1);
});

PS There might be a better way to do handle this using Inquirer, haven't looked into this for a while.

@webpro
Copy link
Collaborator

webpro commented Jul 20, 2015

No reply, so closing this.

@webpro webpro closed this as completed Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants