Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-it only tags source repo #38

Closed
Necroskillz opened this issue Sep 29, 2015 · 2 comments
Closed

Release-it only tags source repo #38

Necroskillz opened this issue Sep 29, 2015 · 2 comments

Comments

@Necroskillz
Copy link
Contributor

Hi,

seems that change in commit 6179c5d made it so that the dist repo is not tagged. I understand from the commit message that this is for the case that dist repo is the same as source repo (dunno when does that make sense), however that is not our case - the source and dist repo are different and both should be tagged.

@webpro
Copy link
Collaborator

webpro commented Sep 29, 2015

The dist repo is the same if the release goes to another branch (example: gh-pages branch).

But I tried to be smart here, and not ask the tag question in that particular case. I'm going to see if I can detect whether src/dist repo have the same origin (probably not a good idea). Otherwise, probably, ending up with asking the tag question twice, always.

@Necroskillz
Copy link
Contributor Author

You can always add another config property which defines whether to tag the dist repo

@webpro webpro closed this as completed in 0bf3dfa Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants