Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts never trigger #415

Closed
drewlustro opened this issue Dec 12, 2018 · 2 comments
Closed

Scripts never trigger #415

drewlustro opened this issue Dec 12, 2018 · 2 comments

Comments

@drewlustro
Copy link

drewlustro commented Dec 12, 2018

I cannot seem to get any scripts to trigger for my main src.

release-it version: 8.4.2

.release-it.json

{
  "scripts": {
    "beforeStart": "yarn test",
    "beforeStage": "yarn build",
    "changelog": "git log --pretty=format:\"* %s (%h)\" [REV_RANGE]",
    "afterRelease": "echo Successfully released ${name} v${version} to ${repo.repository}."
  },
  "src": {
    "tagName": "v${version}"
  },
  "github": {
    "release": true,
    "tokenRef": "RELEASE_IT_GITHUB_TOKEN",
    "commitArgs": "-S"
  },
  "npm": {
    "publish": false,
    "private": true
  }
}

package.json (note the lack of a 'release-it' key)

{
  "name": "packagename",
  "version": "0.2.6",
  "scripts": {
    "build": "yarn build:node && yarn build:gem",
    "build:node": "yarn clean && tsc && rollup -c rollup.config.babel.js",
    "build:gem": "bin/generate_version && gem build halo.gemspec",
    "clean": "rm -rf ./dist/*",
    "prepare": "yarn build",
    "prepublishOnly": "yarn test && yarn lint",
    "test": "jest --config jestconfig.json",
    "dev": "docz dev",
    "docz:dev": "docz dev",
    "docs:dev": "yarn docz:dev",
    "docz:build": "docz build",
    "docs:build": "yarn docz:build",
    "release": "release-it",
  }

  /* ... abridged ... */

}

Run (or dry run) never executes any scripts:

  • beforeStart never executes
  • beforeStage never executes
  • afterRelease never executes
Verbose Debug Log (click to expand)
yarn run v1.9.4
$ release-it --verbose --debug --no-requireCleanWorkingDir
  release-it:config { _: [],
  release-it:config   verbose: true,
  release-it:config   V: true,
  release-it:config   debug: true,
  release-it:config   e: true,
  release-it:config   requireCleanWorkingDir: false,
  release-it:config   increment: 'patch',
  release-it:config   'non-interactive': false,
  release-it:config   scripts:
  release-it:config    { beforeStart: 'yarn test',
  release-it:config      beforeStage: 'yarn build',
  release-it:config      changelog: 'git log --pretty=format:"* +0ms (%h)" [REV_RANGE]',
  release-it:config      afterRelease:
  release-it:config       'echo Successfully released ${name} v${version} to ${repo.repository}.' },
  release-it:config   src:
  release-it:config    { tagName: 'v${version}',
  release-it:config      commit: true,
  release-it:config      commitMessage: 'Release ${version}',
  release-it:config      commitArgs: '',
  release-it:config      tag: true,
  release-it:config      tagAnnotation: 'Release ${version}',
  release-it:config      tagArgs: '',
  release-it:config      push: true,
  release-it:config      pushArgs: '',
  release-it:config      pushRepo: 'origin',
  release-it:config      beforeStartCommand: null,
  release-it:config      afterReleaseCommand: null,
  release-it:config      addUntrackedFiles: false },
  release-it:config   github:
  release-it:config    { release: true,
  release-it:config      tokenRef: 'RELEASE_IT_GITHUB_TOKEN',
  release-it:config      commitArgs: '-S',
  release-it:config      releaseName: 'Release ${version}',
  release-it:config      preRelease: false,
  release-it:config      draft: false,
  release-it:config      assets: null,
  release-it:config      host: null,
  release-it:config      timeout: 0,
  release-it:config      proxy: null,
  release-it:config      token: 'de3348d7f675d58a905a0e142dcd79b732dbff26' },
  release-it:config   npm:
  release-it:config    { publish: false,
  release-it:config      private: true,
  release-it:config      version: '0.2.6',
  release-it:config      name: 'halo',
  release-it:config      publishPath: '.',
  release-it:config      tag: 'latest',
  release-it:config      access: null,
  release-it:config      otp: null },
  release-it:config   name: 'halo',
  release-it:config   'dry-run': false,
  release-it:config   pkgFiles: [ 'package.json' ],
  release-it:config   preReleaseId: null,
  release-it:config   buildCommand: null,
  release-it:config   safeBump: true,
  release-it:config   beforeChangelogCommand: null,
  release-it:config   changelogCommand: 'git log --pretty=format:"* %s (%h)" [REV_RANGE]',
  release-it:config   requireUpstream: true,
  release-it:config   dist:
  release-it:config    { repo: false,
  release-it:config      stageDir: '.stage',
  release-it:config      baseDir: 'dist',
  release-it:config      files: [ '**/*' ],
  release-it:config      pkgFiles: null,
  release-it:config      commit: true,
  release-it:config      commitMessage: 'Release ${version}',
  release-it:config      commitArgs: '',
  release-it:config      tag: true,
  release-it:config      tagName: '${version}',
  release-it:config      tagAnnotation: 'Release ${version}',
  release-it:config      tagArgs: '',
  release-it:config      push: true,
  release-it:config      pushArgs: '',
  release-it:config      beforeStageCommand: null,
  release-it:config      afterReleaseCommand: null,
  release-it:config      addUntrackedFiles: null,
  release-it:config      github: { release: false },
  release-it:config      npm: { publish: false } },
  release-it:config   prompt:
  release-it:config    { src:
  release-it:config       { status: false,
  release-it:config         commit: true,
  release-it:config         tag: true,
  release-it:config         push: true,
  release-it:config         release: true,
  release-it:config         publish: true },
  release-it:config      dist:
  release-it:config       { status: false,
  release-it:config         commit: true,
  release-it:config         tag: false,
  release-it:config         push: true,
  release-it:config         release: false,
  release-it:config         publish: false } } }
$ git rev-parse --git-dir
.git
  release-it:shell { command: 'git rev-parse --git-dir',
  release-it:shell   options: { isReadOnly: true },
  release-it:shell   code: 0,
  release-it:shell   stdout: '.git',
  release-it:shell   stderr: '' } +0ms
$ git config --get remote.origin.url
git@github.com:venturehacks/halo.git
  release-it:shell { command: 'git config --get remote.origin.url',
  release-it:shell   options: { isReadOnly: true },
  release-it:shell   code: 0,
  release-it:shell   stdout: 'git@github.com:venturehacks/halo.git',
  release-it:shell   stderr: '' } +14ms
$ git rev-parse --abbrev-ref --symbolic-full-name @{u}
origin/master
  release-it:shell { command: 'git rev-parse --abbrev-ref --symbolic-full-name @{u}',
  release-it:shell   options: { isReadOnly: true },
  release-it:shell   code: 0,
  release-it:shell   stdout: 'origin/master',
  release-it:shell   stderr: '' } +13ms
$ git describe --tags --abbrev=0
v0.2.5
  release-it:shell { command: 'git describe --tags --abbrev=0',
  release-it:shell   options: { isReadOnly: true },
  release-it:shell   code: 0,
  release-it:shell   stdout: 'v0.2.5',
  release-it:shell   stderr: '' } +15ms
WARNING Latest Git tag (0.2.5) doesn't match package.json#version (0.2.6).
$ git show-ref --tags --quiet --verify -- "refs/tags/v0.2.5"
  release-it:catchall { statusCode: 200,
  release-it:catchall   statusMessage: 'OK',
  release-it:catchall   url: 'http://www.google-analytics.com/collect' } +0ms
  release-it:shell { command: 'git show-ref --tags --quiet --verify -- "refs/tags/v0.2.5"',
  release-it:shell   options: { isReadOnly: true },
  release-it:shell   code: 0,
  release-it:shell   stdout: '',
  release-it:shell   stderr: '' } +20ms
$ git log --pretty=format:"* %s (%h)" v0.2.5...HEAD
* Add beforeStart + beforeStage hooks to release-it (196f770)
* Update .release-it.json (6886c3e)
* Release hooks & clean-up (38d635b)
* Fix Jest testrunner for typescript (df92a01)
* Use package.json as VERSION authority (933e475)  release-it:shell { command: 'git log --pretty=format:"* +15ms (%h)" v0.2.5...HEAD',
  release-it:shell   options: { isReadOnly: true },
  release-it:shell   code: 0,
  release-it:shell   stdout:
  release-it:shell    '* Add beforeStart + beforeStage hooks to release-it (196f770)\n* Update .release-it.json (6886c3e)\n* Release hooks & clean-up (38d635b)\n* Fix Jest testrunner for typescript (df92a01)\n* Use package.json as VERSION authority (933e475)',
  release-it:shell   stderr: '' }

? Ready to release v0.2.6? Yes
$ bump package.json 0.2.6
$ git add package.json
  release-it:shell { command: 'git add package.json',
  release-it:shell   options: {},
  release-it:shell   code: 0,
  release-it:shell   stdout: '',
  release-it:shell   stderr: '' } +21s
$ git add . --update
  release-it:shell { command: 'git add . --update',
  release-it:shell   options: {},
  release-it:shell   code: 0,
  release-it:shell   stdout: '',
  release-it:shell   stderr: '' } +18ms
? Show staged files? No
? Commit (Release 0.2.6)? Yes
$ git commit --message="Release 0.2.6"
[master 209ca14] Release 0.2.6
 1 file changed, 1 insertion(+), 1 deletion(-)
  release-it:shell { command: 'git commit --message="Release 0.2.6" ',
  release-it:shell   options: '.',
  release-it:shell   code: 0,
  release-it:shell   stdout:
  release-it:shell    '[master 209ca14] Release 0.2.6\n 1 file changed, 1 insertion(+), 1 deletion(-)',
  release-it:shell   stderr: '' } +7s
? Tag (v0.2.6)? Yes
$ git tag --annotate --message="Release 0.2.6"  v0.2.6
  release-it:shell { command: 'git tag --annotate --message="Release 0.2.6"  v0.2.6',
  release-it:shell   options: { verbose: true },
  release-it:shell   code: 0,
  release-it:shell   stdout: '',
  release-it:shell   stderr: '' } +7s
? Push? Yes
$ git push --follow-tags  origin
To github.com:venturehacks/halo.git
   69c23e6..209ca14  master -> master
 * [new tag]         v0.2.6 -> v0.2.6
  release-it:shell { command: 'git push --follow-tags  origin ',
  release-it:shell   options: {},
  release-it:shell   code: 0,
  release-it:shell   stdout: '',
  release-it:shell   stderr:
  release-it:shell    'To github.com:venturehacks/halo.git\n   69c23e6..209ca14  master -> master\n * [new tag]         v0.2.6 -> v0.2.6\n' } +21s
? Create a release on GitHub (Release 0.2.6)? Yes
$ octokit releases#createRelease
octokit releases#createRelease: done (https://api.github.com/repos/venturehacks/halo/releases/14500100 v0.2.6 "Release 0.2.6")
  release-it:catchall { statusCode: 200,
  release-it:catchall   statusMessage: 'OK',
  release-it:catchall   url: 'http://www.google-analytics.com/collect' } +1m
✨  Done in 67.00s.
@webpro
Copy link
Collaborator

webpro commented Dec 12, 2018

Hi @drewlustro!

My apologies for this. Last night I've released the first beta of v9, and you are looking at the docs of the master branch, while (obviously) still on release-it v8.

Two options:

  1. Use the docs for v8.4.2: https://github.com/webpro/release-it/blob/8.4.2/README.md
  2. Upgrade to the beta of v9 npm install release-it@beta.

I'll update the docs shortly so others don't experience this as well.

@webpro webpro closed this as completed in 2ee03e5 Dec 12, 2018
@drewlustro
Copy link
Author

Bahaha god damn. Definitely lost almost an hour to that.

Thank you for the extremely rapid response! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants