Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] allow granular control over prerelease flag in github #679

Closed
ahmadnassri opened this issue Jun 23, 2020 · 4 comments
Closed
Labels

Comments

@ahmadnassri
Copy link

currently the prerelease flag on github releases is driven by parsing the version number, however, this does not accurately mirror the functionality by github itself.

the flag on github is simply a flag, and has no relation to the version number:

image

the use-case here would be to allow incrementing semver numbers normally, without relying on suffix values or requiring a follow up increment to move from "prerelease" to "produciton" which in github is an action of unchecking the box

@webpro
Copy link
Collaborator

webpro commented Jun 23, 2020

Yes, there is the --github.preRelease setting for this.

(Setting e.g. --preRelease=next sets this automatically indeed.)

@ahmadnassri
Copy link
Author

in my testing doing --github.preRelease does nothing by itself (and looking at the code, it seems to also confirm that, unless i'm misreading it)

using --preRelease does indeed work, but then it overwrites the version number to do a "prerelease" as per semver standard ...

so what i'm looking for is being able to check the box in github, without modifying the version numbering scheme

@webpro
Copy link
Collaborator

webpro commented Jun 23, 2020

Right, in that case it's a bug, unfortunately. --github.preRelease should just work.

@webpro webpro added the bug label Jun 23, 2020
@webpro webpro closed this as completed in 49742cb Aug 22, 2020
@webpro
Copy link
Collaborator

webpro commented Aug 22, 2020

The fix for this landed in v13.6.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants