feat : add a host info when generating web url #828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there 馃憢
I'm using this package in a Github enterprise.
When I use github release automatically, It's working well.
But if it's manual, The generated url is always github link. (not enterprise link)
So I added host information to
generateWebUrl
function.For a similar code convention, I referred to the following.
release-it/lib/plugin/github/GitHub.js
Lines 152 to 153 in 7286e6e
Thank you for your hard work.