Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add a host info when generating web url #828

Merged
merged 1 commit into from Nov 27, 2021

Conversation

taenykim
Copy link
Contributor

@taenykim taenykim commented Oct 28, 2021

Hi, there 馃憢
I'm using this package in a Github enterprise.

When I use github release automatically, It's working well.
But if it's manual, The generated url is always github link. (not enterprise link)
So I added host information to generateWebUrl function.

For a similar code convention, I referred to the following.

const host = this.options.host || this.getContext('repo.host');
const isGitHub = host === 'github.com';

Thank you for your hard work.

 - If site is other (ie. Enterprise) use other host info
@webpro webpro merged commit 1b1034c into release-it:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants