-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backticks in commit message results in missing text in the github release #870
Comments
Could you try with a |
So the text is missing already on running release script in the command line. This is even before the github page is opened. I've tried both with and without the GITHUB_TOKEN and the result is the same.
Notice that the |
And this is the configuration that that project uses: https://github.com/nuxt-community/sentry-module/blob/99222475993865dc7a05eda40eaafec4726b7aa8/.release-it.js |
Alright, thanks for clearing that up. Will investigate soon. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still an issue. I'm short on time but might look at it myself if the resources are short on your side also. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I've debugged it and figured out that this is due to using github: {
release: true,
releaseName: '${version}',
releaseNotes: 'echo "${changelog}" | sed 1,2d'
},
So I guess I need to find some other command that will do the same job. |
Using single quotes around |
I have been experimenting with supporting a JS function for
I like this solution because it allows me to avoid slow shell scripts and is much simpler to deal with when it comes to weird escaping needed for shell scripts. And avoids dealing with horrible bash syntax (personal take). That said, one wouldn't be able to use functions in json config so not sure if you are open to it and also, for consistency, we might have to (or want to) support the same in other options that currently run shell scripts... |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@rchl Sorry for the late reply. A function for |
I have included backticks in my commit message, for example here in the body of the commit:
Then I've proceeded to release a new version which included this text properly in the CHANGELOG.md as:
But the text included in the Github release was missing the text in the backticks entirely and looked something like this (I've now manually fixed it):
(Ignore the fact that I have failed to include the commit summary in the "BREAKING CHANGE" section which makes this changelog somewhat confusing).
Repro steps:
yarn && yarn release major --preRelease=beta
The
--preRelease
stuff is likely not relevant but that's what I've used.Also note that I haven't provided the
GITHUB_TOKEN
token so the github release was done manually through the browser. That's probably where it went wrong although I haven't noticed at first.The text was updated successfully, but these errors were encountered: