Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prerelase): pass prerelease option to get_current_version #432

Merged
merged 1 commit into from
Apr 3, 2022
Merged

fix(prerelase): pass prerelease option to get_current_version #432

merged 1 commit into from
Apr 3, 2022

Conversation

anehx
Copy link
Contributor

@anehx anehx commented Mar 30, 2022

The get_current_version function accepts a prerelease argument which was never passed.

@anehx
Copy link
Contributor Author

anehx commented Mar 30, 2022

The test for this never failed because it was mocked correctly:

https://github.com/relekang/python-semantic-release/blob/85158798ca438c1dafc84036d13c2988c934f02f/tests/test_cli.py#L357-L359

However, get_current_version could never have returned this value because the prerelease_bool argument was never passed which lead to ignoring all prereleases:

https://github.com/relekang/python-semantic-release/blob/85158798ca438c1dafc84036d13c2988c934f02f/semantic_release/history/__init__.py#L230

danth
danth requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@danth danth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests.

@anehx
fix(prerelase): pass prerelease option to get_current_version
890de63 
The `get_current_version` function accepts a `prerelease` argument which
was never passed.
@anehx
Copy link
Contributor Author

anehx commented Mar 31, 2022

@danth the tests should pass now..

@danth danth merged commit aabab0b into python-semantic-release:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danth danth danth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anehx @danth