feat(changelog): add PR links in markdown #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley-changelog-replace-pr-links
branch
from
52ced32
to
9d0d988
Compare
wyardley
changed the title
|
Open to suggestions on style / formatting here. I decided to do the f string for the table formatting in two lines, and to put the spaces at the beginning of the next line for the tests, but not super married to either way of doing it. Similarly, could easily make the regex part little terser or change stuff there if it would be preferred. |
wyardley
force-pushed
the
wyardley-changelog-replace-pr-links
branch
from
9d0d988
to
a3baf4f
Compare
danth
reviewed
Dec 5, 2020
wyardley
force-pushed
the
wyardley-changelog-replace-pr-links
branch
2 times, most recently
from
241c1e0
to
7a48056
Compare
GitHub release notes automagically link to the PR, but changelog markdown doesn't. Replace (python-semantic-release#123) at the end of a message with a markdown link.
wyardley
force-pushed
the
wyardley-changelog-replace-pr-links
branch
from
7a48056
to
b45e159
Compare
|
Also, we may want to (fairly soon) update the gitlab ones to follow the same hostname as for the API, assuming that's the correct behavior, but that would probably go along with the changes I mentioned in #277 |
danth
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub release notes automagically link to the PR, but changelog markdown doesn't. Replace (#123) at the end of a message with a markdown link.