feat: add toml files support for version declaration (#245, #275) #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toilal
force-pushed
the
pyproject-toml-support
branch
4 times, most recently
from
8fd67d2
to
a985680
Compare
Toilal
force-pushed
the
pyproject-toml-support
branch
from
a985680
to
374f521
Compare
Toilal
commented
Jan 7, 2021
Toilal
force-pushed
the
pyproject-toml-support
branch
2 times, most recently
from
346ed4f
to
073d748
Compare
danth
reviewed
Jan 25, 2021
…-release#245, python-semantic-release#275) This introduce a new `version_toml` configuration property that behaves like `version_pattern` and `version_variable`. For poetry support, user should now set `version_toml = pyproject.toml:tool.poetry.version`. This introduce an ABC class, `VersionDeclaration`, that can be implemented to add other version declarations with ease. `toml` dependency has been replaced by `tomlkit`, as this is used the library used by poetry to generate the `pyproject.toml` file, and is able to keep the ordering of data defined in the file. Existing `VersionPattern` class has been renamed to `PatternVersionDeclaration` and now implements `VersionDeclaration`. `load_version_patterns()` function has been renamed to `load_version_declarations()` and now return a list of `VersionDeclaration` implementations. Close python-semantic-release#245 Close python-semantic-release#275
Toilal
force-pushed
the
pyproject-toml-support
branch
from
073d748
to
fedeea8
Compare
danth
approved these changes
Jan 26, 2021
This was referenced Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce a new
version_tomlconfiguration property that behaves likeversion_patternandversion_variable.For poetry support, user should now set
version_toml = pyproject.toml:tool.poetry.version.This introduce an ABC class,
VersionDeclaration, that can be implemented to add other version declarations with ease.tomldependency has been replaced bytomlkit, as this is used the library used by poetry to generate thepyproject.tomlfile, and is able to keep the ordering of data defined in the file.Existing
VersionPatternclass has been renamed toPatternVersionDeclarationand now implementsVersionDeclaration.load_version_patterns()function has been renamed toload_version_declarations()and now return a list ofVersionDeclarationimplementations.Close #245
Close #275