-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to finding previous version from tags if not using commit messages #68
Add support to finding previous version from tags if not using commit messages #68
Conversation
Now grabs the previous version from tag names if it can't find it in the commit
semantic_release/cli.py
Outdated
log = generate_changelog( | ||
get_previous_version(current_version), current_version) | ||
if current_version is None: | ||
raise Exception("Unable to get the current verison." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more clear? Is it a variable name? The exception string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, verison
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. That surprisingly gets me a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully @relekang will review and merge stuff soon, I have a PR waiting too.
Master has been updated with CI integration, do you mind rebasing on master so CI will build? |
semantic_release/cli.py
Outdated
log = generate_changelog( | ||
get_previous_version(current_version), current_version) | ||
if current_version is None: | ||
raise Exception("Unable to get the current version." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ImproperConfigurationError
yea, looks like some conflicts so it'll take some time but i'l ltry to get it done today |
rebasing proved difficult, but the merge was pretty simple |
Maybe I need to re-create the pull request? |
Thanks ✌️ |
It seems python2 broke after one of the recent pull-requests I hope to have a look at it soon and then do a release. |
This have been released in v3.11.0 |
I was converting an older project, and having a bit of a hard time. Took me a while the
system was looking specifically for a commit with a message of "v\d+.\d+.\d+"
This allows annotated tags with version names to work as well