Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to finding previous version from tags if not using commit messages #68

Merged

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Jun 7, 2017

I was converting an older project, and having a bit of a hard time. Took me a while the
system was looking specifically for a commit with a message of "v\d+.\d+.\d+"

This allows annotated tags with version names to work as well

Now grabs the previous version from tag names if it can't find it in the commit
log = generate_changelog(
get_previous_version(current_version), current_version)
if current_version is None:
raise Exception("Unable to get the current verison."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more clear? Is it a variable name? The exception string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, verison.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. That surprisingly gets me a lot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully @relekang will review and merge stuff soon, I have a PR waiting too.

@relekang
Copy link
Member

Master has been updated with CI integration, do you mind rebasing on master so CI will build?

log = generate_changelog(
get_previous_version(current_version), current_version)
if current_version is None:
raise Exception("Unable to get the current version."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ImproperConfigurationError

@halkeye
Copy link
Contributor Author

halkeye commented Apr 10, 2018

yea, looks like some conflicts so it'll take some time but i'l ltry to get it done today

@halkeye
Copy link
Contributor Author

halkeye commented Apr 11, 2018

rebasing proved difficult, but the merge was pretty simple

@halkeye
Copy link
Contributor Author

halkeye commented Apr 11, 2018

Maybe I need to re-create the pull request?

@relekang relekang merged commit 6786487 into python-semantic-release:master Apr 12, 2018
@relekang
Copy link
Member

Thanks ✌️

@relekang
Copy link
Member

It seems python2 broke after one of the recent pull-requests I hope to have a look at it soon and then do a release.

@relekang
Copy link
Member

This have been released in v3.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants