Use keyword arguments in thumbnail url

python-thumbnails · Apr 11, 2015 · a04895b · a04895b
1 parent ae38602
commit a04895b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/docs/settings.rst b/docs/settings.rst
@@ -119,5 +119,5 @@ Dummy thumbnails
 
     | This is the url that the dummy url is generated from. It should be a
       string that can be used with ``string.format`` and the arguments are width
-      and height, ``THUMBNAIL_DUMMY_URL.format(width, height)``
-    | **Default:** `http://puppies.lkng.me/{}x{}`
+      and height, ``THUMBNAIL_DUMMY_URL.format(width=width, height=height)``
+    | **Default:** `http://puppies.lkng.me/{width}x{height}`
diff --git a/thumbnails/conf/defaults.py b/thumbnails/conf/defaults.py
@@ -20,4 +20,4 @@
 THUMBNAIL_FILTER_OPTIONS = {'size': '500'}
 
 THUMBNAIL_DUMMY = False
-THUMBNAIL_DUMMY_URL = 'http://puppies.lkng.me/{}x{}'
+THUMBNAIL_DUMMY_URL = 'http://puppies.lkng.me/{width}x{height}'
diff --git a/thumbnails/engines/dummy.py b/thumbnails/engines/dummy.py
@@ -19,7 +19,7 @@ def create(self, original, size, crop, options=None):
         return thumbnail
 
     def _get_url(self, size):
-        return settings.THUMBNAIL_DUMMY_URL.format(size[0], size[1])
+        return settings.THUMBNAIL_DUMMY_URL.format(width=size[0], height=size[1])
 
     def cleanup(self, original):
         pass