Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcov and #should vs. #expect matchers #100

Closed
oddlyzen opened this issue Oct 15, 2013 · 2 comments
Closed

Rcov and #should vs. #expect matchers #100

oddlyzen opened this issue Oct 15, 2013 · 2 comments

Comments

@oddlyzen
Copy link

We've seen some seemingly bizarre behavior in some of our coverage runs as of late (specifically code reported as uncovered when we are obiously covering it) and in attempting to track down the issues, I've noticed that much of the spec code uses the older #should-style rather that Rspec's #expect matchers. Many of the newer specs use the newer syntax. Could it be possible that the combination of the old- and new-style matchers is causing code to report as uncovered when it is? Thanks in advance.

@abedra
Copy link
Contributor

abedra commented Oct 15, 2013

Two quick questions.

  • Are you still using Ruby 1.8.x?
  • Can you provide a runnable sample?

I have some ideas about what might be going on, but I need a reproducible example to be able to fix it. If you are on Ruby 1.8.x please consider upgrading to at least 1.9.x or higher due to the lack of continued security updates on the 1.8.x branch. Also, if you upgrade, you should move to simplecov. Happy to take a look at this provided an example though.

@oddlyzen
Copy link
Author

@abedra Yes, we are on 1.8.7. Also, after looking through some of the other issues, I think this might be related to namespaces. I believe this issue can be closed. Thanks—and my apologies for not getting back to you sooner.

Cheers! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants