Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify FormSubmission and AttackFormSubmission #8

Closed
glv opened this issue Jun 21, 2009 · 1 comment
Closed

Unify FormSubmission and AttackFormSubmission #8

glv opened this issue Jun 21, 2009 · 1 comment
Labels

Comments

@glv
Copy link
Contributor

glv commented Jun 21, 2009

These two classes are an embarrassment of duplicated code. The default fuzzing strategy implemented in FormSubmission should be implemented as (say) BasicAttackHandler, and AttackFormSubmission should be renamed to FormSubmission with BasicAttachHandler included by default in the set of attacks.

(As part of this, the distinction between fuzzers and attacks can be eliminated in Crawler; a fuzzer is an attack, and the artificial distinction is confusing. Note that this will be an incompatible change, because the distinction is exposed in test cases. But it's still the right thing to do.)

@glv
Copy link
Contributor Author

glv commented Sep 4, 2009

Fixed by 837628b

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant