Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets blocked by uBlock origin #8

Closed
AMDG2 opened this issue Dec 4, 2019 · 11 comments
Closed

Assets blocked by uBlock origin #8

AMDG2 opened this issue Dec 4, 2019 · 11 comments
Assignees
Milestone

Comments

@AMDG2
Copy link

AMDG2 commented Dec 4, 2019

uBlock origin is blocking asset loading because of the 'analytics/js' inside the path.

Firefox Console:
image

uBlock Origin Logger:
image

I will try to find which list contains this filter.

@AMDG2 AMDG2 mentioned this issue Dec 4, 2019
@Rello
Copy link
Owner

Rello commented Dec 4, 2019

hello,
Thats really an interesting finding. but this will be the reason for #6 also
not good

@AMDG2
Copy link
Author

AMDG2 commented Dec 4, 2019

EasyPrivacy from https://easylist.to/ contains this filter. I think it is a very common list so it is very probably included in other adblockers or privacy tools.

Maybe you could change the app name ?

@Rello
Copy link
Owner

Rello commented Dec 4, 2019

@nickvergessen
a widely used block-list includes a filter for /analytics/js$script
this is where my App is being blogged.

I think it can be avoided by using a different subfolder than /js for the scripts.
Do you have an idea if this would be possible? because all the Util::addScript('analytics', 'app'); depend on this folder. can a different subfolder be used via parameter?

thank you

@nickvergessen
Copy link

You can have subfolders inside js/
But you can not replace js/ I think.
Maybe you can detect it and recomment to disable ublock for your own nextcloud, or you rename your app again to e.g. data_visualization

@Rello
Copy link
Owner

Rello commented Dec 4, 2019

@nickvergessen a rename would mean a new app release because there is no rename process available, correct?
for the remain, the <id>analytics</id> would be the one, not the <namespace>Analytics</namespace>, correct?

@nickvergessen
Copy link

yes, <id> needs changing, but that value must match the folder name and the entry in the appstore, and .... (exactly the reason why Talk is still running with the appid spreed 😿 )

@Rello
Copy link
Owner

Rello commented Dec 5, 2019

@nickvergessen
Yes, I could include a start screen message in my App to disable AdBlock (and hide this message via js, if its working)

But it seems a workaround if we are planning for a wider use of DA.
DA has 200users already. They need to be informed to install the new app.

I think about ‚data_analytics‘.
Later enhancing with modules like ‚data_extraction‘ or ‚data_reporting‘

@Rello
Copy link
Owner

Rello commented Dec 5, 2019

@AMDG2 the implication of changing the app is quite some issue. can you confirm that uBlock can be disabled for your NC-Domain only to make Data Analytics work?

@AMDG2
Copy link
Author

AMDG2 commented Dec 5, 2019

Yes, for sure. My guess is that it would be the same for adblocker users with any nextcloud instance. Usually they don't have any tracking or advertisement on Nextcloud 😅 so it should not be an issue.

@Rello
Copy link
Owner

Rello commented Dec 5, 2019

thank you for your feedback.
I am in contact with the creators of Easylist already. In parallel I am implementing a proper warning page

After deactivating uBlock, I hope you enjoy Data Analytics

@Rello
Copy link
Owner

Rello commented Dec 5, 2019

User warning implemented;
Screenshot 2019-12-05 at 23 28 40

wiki provided https://github.com/Rello/analytics/wiki/EasyPrivacy-Blocklist;

@Rello Rello added this to the 1.1.0 milestone Dec 5, 2019
@Rello Rello added the pending release part of the next release version label Dec 5, 2019
@Rello Rello self-assigned this Dec 5, 2019
@Rello Rello closed this as completed Dec 5, 2019
@Rello Rello removed the pending release part of the next release version label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants