Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update relm4-components for the new component trait #101

Closed
4 tasks
AaronErhardt opened this issue Feb 2, 2022 · 4 comments · Fixed by #229
Closed
4 tasks

Update relm4-components for the new component trait #101

AaronErhardt opened this issue Feb 2, 2022 · 4 comments · Fixed by #229
Labels
help wanted Extra attention is needed
Milestone
0.5

Comments

@AaronErhardt
Copy link
Member

It'd be nice to support relm4-components in 0.5 from day one. These are the currently available components:

  • open_button
  • alert
  • open_dialog
  • save_dialog

And of course, more reusable components are always welcome!
@AaronErhardt AaronErhardt added the help wanted Extra attention is needed label Feb 2, 2022
@AaronErhardt AaronErhardt added this to the 0.5 milestone Feb 2, 2022
@MaksymShcherbak
Copy link
Member

I'd like to work on this issue.

@AaronErhardt
Copy link
Member Author

Awesome! Let me know if you need any help.

@euclio
Copy link
Member

euclio commented Mar 21, 2022

How are the components expected to access their parent? By passing it through InitParams?

@AaronErhardt
Copy link
Member Author

Yes, the new component design makes them independent from their parent unless they require specific InitParams to access the parent. You can also forward the Output of the child to the Input of the parent.

@euclio euclio mentioned this issue Mar 27, 2022
Merged
@MaksymShcherbak MaksymShcherbak mentioned this issue Mar 27, 2022
Merged
@euclio euclio mentioned this issue Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

re-enable relm4-components euclio/relm4
3 participants
@euclio @AaronErhardt @MaksymShcherbak