Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny defaced, acceded, effaced #20

Closed
wooorm opened this issue Mar 13, 2020 · 0 comments
Closed

Deny defaced, acceded, effaced #20

wooorm opened this issue Mar 13, 2020 · 0 comments
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🐛 type/bug This is a problem

Comments

@wooorm
Copy link
Member

wooorm commented Mar 13, 2020 •
edited

defaced, acceded, and effaced are words that sometimes appears in actual text, and most likely don’t appear as a SHA. Deny them too:

remark-github/lib/tokenizer/hash.js

Line 28 in 3cf0e0b

var denylist = ['deedeed', 'fabaceae']

@wooorm wooorm changed the title Deny defaced Deny defaced, acceded, effaced Mar 13, 2020
@wooorm wooorm closed this as completed in e35d69c Mar 23, 2020
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🧑 semver/major This is a change and removed 🔍 status/open labels Mar 23, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🐛 type/bug This is a problem
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wooorm