Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\r\n problem in maximum-line-length.js for previous releases (versions 5.x.x) #179

Closed
bessorion opened this issue May 3, 2018 · 3 comments
Labels
🙋 no/question This does not need any changes

Comments

@bessorion
Copy link

Hi, there are problem with line-endings in maximum-line-length.js vor version 5.
Please see qmlweb/qmlweb#435 for details.
This problem still actual in the latest 5.4.0 also.
I suppose it would be great to release some updates (f.e. 5.4.1) for those who cannot migrate to 6 version right now.

@ChALkeR
Copy link
Contributor

ChALkeR commented May 3, 2018

@bessorion Not sure if that makes sense, actually — that depends on the number of users of pre-6.x versions.

There are modules like mobify-code-style and skypager which directly depend on it, but I have no data on dev deps yet. Will post those here once/if I build those.

The patch is trivial, though — fb15182#diff-53d1aa59a351be2b459e7a29237ff53fR101 fixed it.

@wooorm
Copy link
Member

wooorm commented May 11, 2018

My gut tells me not a lot of people use the older versions. 🤷‍♂️
Why not update the package instead?

@bessorion
Copy link
Author

@wooorm Sometimes it requires many additional efforts

@wooorm wooorm added the 🙋 no/question This does not need any changes label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 no/question This does not need any changes
Development

No branches or pull requests

3 participants