-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot disable no-literal-urls #47
Comments
Nice going, @benbalter! 👍 As it stands, remark-lint and remark are decoupled, so the settings don’t carry over from remark-lint to remark. The reason for the extra angle brackets is because not every flavour of markdown supports literal URLs, so, remark (trying to be the hero), ensures other flavours will understand what you meant too. In writing remark, at the parser level I tried to ensure everything of the users settings is supported (so literal URLs, being part of GFM, are of course read correctly), but in compiling remark tries to support as many as possible flavours. To be honest, although I’m unaware of your reason for wanting literal URLs, I’d say to just change your views and start preferring angle brackets. 😉 Without them, you run into all kinds of problems. For example, npm now has a bug where If you don’t agree, I’d like to know why :) |
Ha. Makes sense. That works for me. Thanks, once again, for the thorough response. |
👌 |
Setting the
no-literal-urls
flag tofalse
suppresses the warning, when runningremark-lint
, but if theoutput
flag is set totrue
, all links are wrapped with<
and>
tags, regardless of theno-literal-urls
flag.This is especially troublesome when
gfm
is set totrue
, as GFM supports autolinking, and thus theoretically the parser shouldn't rewrite the links when outputting.Example (with
gfm: true
andno-literal-urls: false
):Input:
Expected:
(Identical)
Actual:
The text was updated successfully, but these errors were encountered: