feat: babel-preset-remax 支持配置 typescript preset 参数 #420
Conversation
23aa768
to
84f470d
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 826a720:
|
84f470d
to
826a720
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec06619:
|
826a720
to
b24db7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 97.32% 97.34% +0.02%
==========================================
Files 296 297 +1
Lines 3214 3242 +28
Branches 340 349 +9
==========================================
+ Hits 3128 3156 +28
Misses 84 84
Partials 2 2
Continue to review full report at Codecov.
|
b24db7d
to
265ca00
Compare
/rebase |
265ca00
to
fb23667
Compare
@@ -0,0 +1,7 @@ | |||
module.exports = function(api) { | |||
api.cache(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是啥意思
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
]; | ||
const presets = [require('@babel/preset-env')]; | ||
|
||
if (typescript) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里好像永远都是 "true"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没错
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不对。用户可以主动传入 false
。
因为理论上不使用 typescript 的朋友可以关掉这个 preset
fb23667
to
ec06619
Compare
resolve #417